Re: [PATCH v3 09/10] test/qtest: Introduce a new aspeed-smc-utils.c to place common testcases

[Cédric Le Goater]

On 11/27/24 10:15, Jamin Lin wrote:
> The testcases for ASPEED SMC model were placed in aspeed_smc-test.c.
> However, this test file only supports for ARM32. To support all ASPEED SOCs
> such as AST2700 whose CPU architecture is aarch64, introduces a new
> aspeed-smc-utils source file and move all common APIs and testcases
> from aspeed_smc-test.c to aspeed-smc-utils.c.
>
> Finally, users are able to re-used these testcase for AST2700 and future
> ASPEED SOCs testing.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>   tests/qtest/aspeed-smc-utils.c | 686 ++++++++++++++++++++++++++++
>   tests/qtest/aspeed-smc-utils.h |  95 ++++
>   tests/qtest/aspeed_smc-test.c  | 800 +++------------------------------
>   tests/qtest/meson.build        |   1 +
>   4 files changed, 841 insertions(+), 741 deletions(-)
>   create mode 100644 tests/qtest/aspeed-smc-utils.c
>   create mode 100644 tests/qtest/aspeed-smc-utils.h
Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.