Re: [PATCH 02/10] target/arm: Move TLBI insns for AArch32 EL2 to tlbi_insn_helper.c

[Peter Maydell]

On Tue, 10 Dec 2024 at 18:11, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 12/10/24 10:04, Peter Maydell wrote:
> > Move the AArch32 TLBI insns for AArch32 EL2 to tlbi_insn_helper.c.
> > To keep this as an obviously pure code-movement, we retain the
> > same condition for registering tlbi_el2_cp_reginfo that we use for
> > el2_cp_reginfo. We'll be able to simplify this condition later,
> > since the need to define the reginfo for EL3-without-EL2 doesn't
> > apply for the TLBI ops specifically.
> >
> > This move brings all the uses of tlbimva_hyp_write() and
> > tlbimva_hyp_is_write() back into a single file, so we can move those
> > also, and make them file-local again.
> >
> > The helper alle1_tlbmask() is an exception to the pattern that we
> > only need to make these functions global temporarily, because once
> > this refactoring is complete it will be called by both code in
> > helper.c (vttbr_write()) and by code in tlb-insns.c.  We therefore
> > put its prototype in a permanent home in internals.h.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> >   target/arm/cpregs.h        |  4 --
> >   target/arm/internals.h     |  6 +++
> >   target/arm/helper.c        | 74 +--------------------------------
> >   target/arm/tcg/tlb-insns.c | 85 ++++++++++++++++++++++++++++++++++++++
>
> Subject has an out-of-date filename.

Yep; as you've probably guessed I changed my mind part way
through about the best name for it ;-)

-- PMM