Re: [PATCH v3 08/24] migration: Add thread pool of optional load threads

[Maciej S. Szmigiero]

On 5.12.2024 17:15, Peter Xu wrote:
> On Wed, Dec 04, 2024 at 05:48:52PM -0500, Peter Xu wrote:
> > > > > @@ -71,6 +72,10 @@
> > > > >    const unsigned int postcopy_ram_discard_version;
> > > > > +static ThreadPool *load_threads;
> > > > > +static int load_threads_ret;
> > > > > +static bool load_threads_abort;
>
> One thing I forgot to mention in the previous reply..
>
> We should avoid adding random global vars.  I hope we can still move these
> into MigrationIncomingState.

Sure, this should be possible even if the thread pool
initialization happens in qemu_loadvm_state_setup().

Thanks,
Maciej