[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/72] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR regi
From: |
Peter Maydell |
Subject: |
[PULL 03/72] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register |
Date: |
Wed, 11 Dec 2024 16:18:55 +0000 |
From: Bernhard Beschow <shentey@gmail.com>
Turns 0x70 into 0xe0 (== 0x70 << 1) which adds the missing MII_ANLPAR_TX and
fixes the MSB of selector field to be zero, as specified in the datasheet.
Fixes: 2a424990170b "LAN9118 emulation"
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20241102125724.532843-4-shentey@gmail.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/net/lan9118_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/lan9118_phy.c b/hw/net/lan9118_phy.c
index d2dcd732ac1..d8fc9ddd3ac 100644
--- a/hw/net/lan9118_phy.c
+++ b/hw/net/lan9118_phy.c
@@ -54,7 +54,7 @@ uint16_t lan9118_phy_read(Lan9118PhyState *s, int reg)
val = s->advertise;
break;
case 5: /* Auto-neg Link Partner Ability */
- val = 0x0f71;
+ val = 0x0fe1;
break;
case 6: /* Auto-neg Expansion */
val = 1;
--
2.34.1
- [PULL 00/72] target-arm queue, Peter Maydell, 2024/12/11
- [PULL 03/72] hw/net/lan9118_phy: Fix off-by-one error in MII_ANLPAR register,
Peter Maydell <=
- [PULL 01/72] hw/net/lan9118: Extract lan9118_phy, Peter Maydell, 2024/12/11
- [PULL 04/72] hw/net/lan9118_phy: Reuse MII constants, Peter Maydell, 2024/12/11
- [PULL 05/72] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement, Peter Maydell, 2024/12/11
- [PULL 06/72] fpu: handle raising Invalid for infzero in pick_nan_muladd, Peter Maydell, 2024/12/11
- [PULL 02/72] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations, Peter Maydell, 2024/12/11
- [PULL 07/72] fpu: Check for default_nan_mode before calling pickNaNMulAdd, Peter Maydell, 2024/12/11
- [PULL 08/72] softfloat: Allow runtime choice of inf * 0 + NaN result, Peter Maydell, 2024/12/11
- [PULL 09/72] tests/fp: Explicitly set inf-zero-nan rule, Peter Maydell, 2024/12/11
- [PULL 10/72] target/arm: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 11/72] target/s390: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11