qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' hel


From: Thomas Huth
Subject: Re: [PATCH v2 08/31] tests/functional: drop 'has_cmd' and 'has_cmds' helpers
Date: Thu, 12 Dec 2024 08:12:57 +0100
User-agent: Mozilla Thunderbird

On 11/12/2024 18.26, Daniel P. Berrangé wrote:
The 'which' helper is simpler and sufficient for test needs.

... and it does not depend on the external "which" program that might not be installed on all host systems, so this is much better indeed!

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  tests/functional/qemu_test/__init__.py   |  2 +-
  tests/functional/qemu_test/cmd.py        | 54 ++----------------------
  tests/functional/qemu_test/tuxruntest.py | 10 ++---
  3 files changed, 9 insertions(+), 57 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]