Re: [PATCH 1/2] system: Restrict libSDL CPPFLAGS to vl.c

[Richard Henderson]

On 12/12/24 03:26, Philippe Mathieu-Daudé wrote:
> Only vl.c includes libSDL headers.
> No need to pass them to all system_ss[] files.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   system/meson.build | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/system/meson.build b/system/meson.build
> index 4952f4b2c7d..f7e2c8b826f 100644
> --- a/system/meson.build
> +++ b/system/meson.build
> @@ -23,8 +23,11 @@ system_ss.add(files(
>     'runstate-hmp-cmds.c',
>     'runstate.c',
>     'tpm-hmp-cmds.c',
> +), libpmem, libdaxctl)
> +
> +system_ss.add(files(
>     'vl.c',
> -), sdl, libpmem, libdaxctl)
> +), sdl)
>   
>   if have_tpm
>     system_ss.add(files('tpm.c'))

I'm sure Paolo will correct me, but I don't think this does what you think it does.  I 
believe this has no change at all.

The presence of sdl within a *particular* source_set.add() call is immaterial.  If the 
condition is true (and here, because the condition is missing it is true), all of the 
files and dependencies get lumped together.  In the end, everything gets copied into 
common_ss.

Both of these patches only alters the order of the items in the link ordering.


r~