[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/i386/cpu: remove default_cpu_version and simplify
From: |
Zhao Liu |
Subject: |
Re: [PATCH] hw/i386/cpu: remove default_cpu_version and simplify |
Date: |
Thu, 12 Dec 2024 22:05:39 +0800 |
> Had a conversation with Igor offline. CPU_VERSION_LATEST does not work since
> it’s a moving target. Therefore for a specific machine, what version of cpu
> model will be chosen will depend on what is latest and this will change with
> time. It can break guests that stick to a single cpu model.
>
> One way to fix this would be to keep a fixed mapping between cpu model and
> machine versions. However, it will be a nightmare to maintain such mappings.
Thanks Ani!
The commit ad18392 also mentioned the plan to move to CPU_VERSION_LATEST.
Because previsou commits have repeatedly mentioned the plan to move to
CPU_VERSION_LATEST (not only the commit dcafd1ef0af227 you referred, but
also the commit ad18392), I think it's necessary to include the
termination of this plan (i.e., your explanation of why you are no longer
attempting to move to CPU_VERSION_LATEST) in the commit message.
This way, the history regarding default_cpu_version will be easier to
search, and it effectively puts an end to the previous plan.
Thanks,
Zhao