[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] hw: Use pci_bus_add_fw_cfg_extra_pci_roots()
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 5/6] hw: Use pci_bus_add_fw_cfg_extra_pci_roots() |
|
Date: |
Fri, 13 Dec 2024 11:34:30 +0000 |
|
User-agent: |
Mutt/2.2.13 (2024-03-09) |
On Fri, Dec 06, 2024 at 07:13:51PM +0100, Philippe Mathieu-Daudé wrote:
> We want to remove fw_cfg_add_extra_pci_roots() which introduced
> PCI bus knowledge within the generic hw/nvram/fw_cfg.c file.
> Replace the calls by the pci_bus_add_fw_cfg_extra_pci_roots()
> which is a 1:1 equivalent, but using correct API.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/arm/virt.c | 3 ++-
> hw/hppa/machine.c | 2 +-
> hw/i386/pc.c | 3 ++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 1/6] hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator(), (continued)
- [PATCH 1/6] hw/nvram/fw_cfg: Rename fw_cfg_add_[file]_from_generator(), Philippe Mathieu-Daudé, 2024/12/06
- [PATCH 2/6] hw/nvram/fw_cfg: Pass QOM parent to fw_cfg_add_file_from_generator(), Philippe Mathieu-Daudé, 2024/12/06
- [PATCH 3/6] hw/pci: Have PCI_BUS implement TYPE_FW_CFG_DATA_GENERATOR_INTERFACE, Philippe Mathieu-Daudé, 2024/12/06
- [PATCH 4/6] hw/pci: Add pci_bus_add_fw_cfg_extra_pci_roots() helper, Philippe Mathieu-Daudé, 2024/12/06
- [PATCH 5/6] hw: Use pci_bus_add_fw_cfg_extra_pci_roots(), Philippe Mathieu-Daudé, 2024/12/06
- Re: [PATCH 5/6] hw: Use pci_bus_add_fw_cfg_extra_pci_roots(),
Daniel P . Berrangé <=
- [PATCH 6/6] hw/nvram/fw_cfg: Remove fw_cfg_add_extra_pci_roots(), Philippe Mathieu-Daudé, 2024/12/06
- Re: [PATCH 0/6] hw/nvram/fw_cfg: Move PCI bus methods out, Philippe Mathieu-Daudé, 2024/12/13