qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/71] whole-tree: Constify Property structures


From: Richard Henderson
Subject: Re: [PATCH 00/71] whole-tree: Constify Property structures
Date: Fri, 13 Dec 2024 13:13:53 -0600
User-agent: Mozilla Thunderbird

On 12/13/24 13:06, Richard Henderson wrote:
Since d36f165d952 (qdev: make properties array "const"), we can
define our Property structure const.  Do this across the entire tree.

There are a few other minor changes:
   - Two instances where it was obvious that an empty property list
     could be removed entirely.  There are other empty lists that
     probably should be removed, but I didn't look further into usage.
   - In hw/misc/xlnx-versal-trng.c, adjust a Property to use the
     correct PropertyInfo in the definition, rather than setting
     it at runtime.
   - One instance where { } was used instead of DEFINE_PROP_END_OF_LIST.
     Not a bug, but wrong style.

I also meant to report that for qemu-system-aarch64 (the only one I checked), this moves 150k from .data to .data.rel.ro. I'm somewhat surprised there's that many, or that Property is as large as it is at 88 bytes.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]