Re: [PATCH 34/71] hw/ipmi: Constify all Property

[Corey Minyard]

Acked-by: Corey Minyard <cminyard@mvista.com>

On Fri, Dec 13, 2024 at 01:07:08PM -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  hw/ipmi/ipmi.c            | 2 +-
>  hw/ipmi/ipmi_bmc_extern.c | 2 +-
>  hw/ipmi/ipmi_bmc_sim.c    | 2 +-
>  hw/ipmi/isa_ipmi_bt.c     | 2 +-
>  hw/ipmi/isa_ipmi_kcs.c    | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c
> index bbb07b151e..850b3bc463 100644
> --- a/hw/ipmi/ipmi.c
> +++ b/hw/ipmi/ipmi.c
> @@ -108,7 +108,7 @@ void ipmi_bmc_find_and_link(Object *obj, Object **bmc)
>                               OBJ_PROP_LINK_STRONG);
>  }
>  
> -static Property ipmi_bmc_properties[] = {
> +static const Property ipmi_bmc_properties[] = {
>      DEFINE_PROP_UINT8("slave_addr",  IPMIBmc, slave_addr, 0x20),
>      DEFINE_PROP_END_OF_LIST(),
>  };
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index 29c5af3cc3..cfec1da87c 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -515,7 +515,7 @@ static void ipmi_bmc_extern_finalize(Object *obj)
>      timer_free(ibe->extern_timer);
>  }
>  
> -static Property ipmi_bmc_extern_properties[] = {
> +static const Property ipmi_bmc_extern_properties[] = {
>      DEFINE_PROP_CHR("chardev", IPMIBmcExtern, chr),
>      DEFINE_PROP_END_OF_LIST(),
>  };
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index 33c839c65a..8a55893e89 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -2191,7 +2191,7 @@ static void ipmi_sim_realize(DeviceState *dev, Error 
> **errp)
>      vmstate_register(NULL, 0, &vmstate_ipmi_sim, ibs);
>  }
>  
> -static Property ipmi_sim_properties[] = {
> +static const Property ipmi_sim_properties[] = {
>      DEFINE_PROP_UINT16("fruareasize", IPMIBmcSim, fru.areasize, 1024),
>      DEFINE_PROP_STRING("frudatafile", IPMIBmcSim, fru.filename),
>      DEFINE_PROP_STRING("sdrfile", IPMIBmcSim, sdr_filename),
> diff --git a/hw/ipmi/isa_ipmi_bt.c b/hw/ipmi/isa_ipmi_bt.c
> index 7b36d51494..16062abb31 100644
> --- a/hw/ipmi/isa_ipmi_bt.c
> +++ b/hw/ipmi/isa_ipmi_bt.c
> @@ -135,7 +135,7 @@ static void *isa_ipmi_bt_get_backend_data(IPMIInterface 
> *ii)
>      return &iib->bt;
>  }
>  
> -static Property ipmi_isa_properties[] = {
> +static const Property ipmi_isa_properties[] = {
>      DEFINE_PROP_UINT32("ioport", ISAIPMIBTDevice, bt.io_base,  0xe4),
>      DEFINE_PROP_INT32("irq",   ISAIPMIBTDevice, isairq,  5),
>      DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/ipmi/isa_ipmi_kcs.c b/hw/ipmi/isa_ipmi_kcs.c
> index f52b32e590..7e7a37659e 100644
> --- a/hw/ipmi/isa_ipmi_kcs.c
> +++ b/hw/ipmi/isa_ipmi_kcs.c
> @@ -142,7 +142,7 @@ static void *isa_ipmi_kcs_get_backend_data(IPMIInterface 
> *ii)
>      return &iik->kcs;
>  }
>  
> -static Property ipmi_isa_properties[] = {
> +static const Property ipmi_isa_properties[] = {
>      DEFINE_PROP_UINT32("ioport", ISAIPMIKCSDevice, kcs.io_base,  0xca2),
>      DEFINE_PROP_INT32("irq",   ISAIPMIKCSDevice, isairq,  5),
>      DEFINE_PROP_END_OF_LIST(),
> -- 
> 2.43.0
>