Re: [PATCH 61/71] hw/tpm: Constify all Property

[Stefan Berger]

On 12/13/24 2:07 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>

> ---
>   hw/tpm/tpm_crb.c        | 2 +-
>   hw/tpm/tpm_spapr.c      | 2 +-
>   hw/tpm/tpm_tis_i2c.c    | 2 +-
>   hw/tpm/tpm_tis_isa.c    | 2 +-
>   hw/tpm/tpm_tis_sysbus.c | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c
> index 5cd5a2533b..2bf6e7ffe9 100644
> --- a/hw/tpm/tpm_crb.c
> +++ b/hw/tpm/tpm_crb.c
> @@ -226,7 +226,7 @@ static const VMStateDescription vmstate_tpm_crb = {
>       }
>   };
>
> -static Property tpm_crb_properties[] = {
> +static const Property tpm_crb_properties[] = {
>       DEFINE_PROP_TPMBE("tpmdev", CRBState, tpmbe),
>       DEFINE_PROP_BOOL("ppi", CRBState, ppi_enabled, true),
>       DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c
> index 5f7a0dfc61..e15b67dd45 100644
> --- a/hw/tpm/tpm_spapr.c
> +++ b/hw/tpm/tpm_spapr.c
> @@ -364,7 +364,7 @@ static const VMStateDescription vmstate_spapr_vtpm = {
>       }
>   };
>
> -static Property tpm_spapr_properties[] = {
> +static const Property tpm_spapr_properties[] = {
>       DEFINE_SPAPR_PROPERTIES(SpaprTpmState, vdev),
>       DEFINE_PROP_TPMBE("tpmdev", SpaprTpmState, be_driver),
>       DEFINE_PROP_END_OF_LIST(),
> diff --git a/hw/tpm/tpm_tis_i2c.c b/hw/tpm/tpm_tis_i2c.c
> index c5548b0a45..b27af230cd 100644
> --- a/hw/tpm/tpm_tis_i2c.c
> +++ b/hw/tpm/tpm_tis_i2c.c
> @@ -491,7 +491,7 @@ static int tpm_tis_i2c_send(I2CSlave *i2c, uint8_t data)
>       return 1;
>   }
>
> -static Property tpm_tis_i2c_properties[] = {
> +static const Property tpm_tis_i2c_properties[] = {
>       DEFINE_PROP_TPMBE("tpmdev", TPMStateI2C, state.be_driver),
>       DEFINE_PROP_END_OF_LIST(),
>   };
> diff --git a/hw/tpm/tpm_tis_isa.c b/hw/tpm/tpm_tis_isa.c
> index 21109edcaa..9b2160972a 100644
> --- a/hw/tpm/tpm_tis_isa.c
> +++ b/hw/tpm/tpm_tis_isa.c
> @@ -91,7 +91,7 @@ static void tpm_tis_isa_reset(DeviceState *dev)
>       return tpm_tis_reset(s);
>   }
>
> -static Property tpm_tis_isa_properties[] = {
> +static const Property tpm_tis_isa_properties[] = {
>       DEFINE_PROP_UINT32("irq", TPMStateISA, state.irq_num, TPM_TIS_IRQ),
>       DEFINE_PROP_TPMBE("tpmdev", TPMStateISA, state.be_driver),
>       DEFINE_PROP_BOOL("ppi", TPMStateISA, state.ppi_enabled, true),
> diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
> index 967f264634..88c1f1e478 100644
> --- a/hw/tpm/tpm_tis_sysbus.c
> +++ b/hw/tpm/tpm_tis_sysbus.c
> @@ -90,7 +90,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev)
>       return tpm_tis_reset(s);
>   }
>
> -static Property tpm_tis_sysbus_properties[] = {
> +static const Property tpm_tis_sysbus_properties[] = {
>       DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ),
>       DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver),
>       DEFINE_PROP_END_OF_LIST(),