Re: [PATCH 65/71] hw/vfio: Constify all Property

[Cédric Le Goater]

On 12/13/24 20:29, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>



Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio/ap.c       | 2 +-
>   hw/vfio/ccw.c      | 2 +-
>   hw/vfio/pci.c      | 4 ++--
>   hw/vfio/platform.c | 2 +-
>   4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
> index 4013e7b436..2e6ea2dd93 100644
> --- a/hw/vfio/ap.c
> +++ b/hw/vfio/ap.c
> @@ -191,7 +191,7 @@ static void vfio_ap_unrealize(DeviceState *dev)
>       g_free(vapdev->vdev.name);
>   }
>   
> -static Property vfio_ap_properties[] = {
> +static const Property vfio_ap_properties[] = {
>       DEFINE_PROP_STRING("sysfsdev", VFIOAPDevice, vdev.sysfsdev),
>   #ifdef CONFIG_IOMMUFD
>       DEFINE_PROP_LINK("iommufd", VFIOAPDevice, vdev.iommufd,
> diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> index c1cd7736cd..b96ab27e12 100644
> --- a/hw/vfio/ccw.c
> +++ b/hw/vfio/ccw.c
> @@ -655,7 +655,7 @@ static void vfio_ccw_unrealize(DeviceState *dev)
>       }
>   }
>   
> -static Property vfio_ccw_properties[] = {
> +static const Property vfio_ccw_properties[] = {
>       DEFINE_PROP_STRING("sysfsdev", VFIOCCWDevice, vdev.sysfsdev),
>       DEFINE_PROP_BOOL("force-orb-pfch", VFIOCCWDevice, force_orb_pfch, false),
>   #ifdef CONFIG_IOMMUFD
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 14bcc725c3..93aca850e3 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -3354,7 +3354,7 @@ static void vfio_instance_init(Object *obj)
>       pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS;
>   }
>   
> -static Property vfio_pci_dev_properties[] = {
> +static const Property vfio_pci_dev_properties[] = {
>       DEFINE_PROP_PCI_HOST_DEVADDR("host", VFIOPCIDevice, host),
>       DEFINE_PROP_UUID_NODEFAULT("vf-token", VFIOPCIDevice, vf_token),
>       DEFINE_PROP_STRING("sysfsdev", VFIOPCIDevice, vbasedev.sysfsdev),
> @@ -3451,7 +3451,7 @@ static const TypeInfo vfio_pci_dev_info = {
>       },
>   };
>   
> -static Property vfio_pci_dev_nohotplug_properties[] = {
> +static const Property vfio_pci_dev_nohotplug_properties[] = {
>       DEFINE_PROP_BOOL("ramfb", VFIOPCIDevice, enable_ramfb, false),
>       DEFINE_PROP_ON_OFF_AUTO("x-ramfb-migrate", VFIOPCIDevice, ramfb_migrate,
>                               ON_OFF_AUTO_AUTO),
> diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c
> index a85c199c76..766e8a86ef 100644
> --- a/hw/vfio/platform.c
> +++ b/hw/vfio/platform.c
> @@ -629,7 +629,7 @@ static const VMStateDescription vfio_platform_vmstate = {
>       .unmigratable = 1,
>   };
>   
> -static Property vfio_platform_dev_properties[] = {
> +static const Property vfio_platform_dev_properties[] = {
>       DEFINE_PROP_STRING("host", VFIOPlatformDevice, vbasedev.name),
>       DEFINE_PROP_STRING("sysfsdev", VFIOPlatformDevice, vbasedev.sysfsdev),
>       DEFINE_PROP_BOOL("x-no-mmap", VFIOPlatformDevice, vbasedev.no_mmap, 
> false),