Re: [PATCH v2 12/34] next-cube: move timer MMIO to separate memory region on next-pc device

[Philippe Mathieu-Daudé]

On 12/12/24 12:45, Mark Cave-Ayland wrote:
> Move the timer MMIO accesses to a separate memory region on the next-pc device
> instead of being part of the next.scr MMIO memory region.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Thomas Huth <huth@tuxfamily.org>
> ---
>   hw/m68k/next-cube.c | 63 +++++++++++++++++++++++++++++++++++----------
>   1 file changed, 50 insertions(+), 13 deletions(-)


> +static uint64_t next_timer_read(void *opaque, hwaddr addr, unsigned size)
> +{
> +    uint64_t val;
> +
> +    switch (addr) {
> +    case 0 ... 3:
> +        /*
> +         * These 4 registers are the hardware timer, not sure which register
> +         * is the latch instead of data, but no problems so far.
> +         *
> +         * Hack: We need to have the LSB change consistently to make it work
> +         */
> +        val = extract32(clock(), (4 - addr - size) << 3,
> +                        size << 3);

Does this mean ...

> +        break;
> +
> +    default:
> +        g_assert_not_reached();
> +    }
> +
> +    return val;
> +}
> +
> +static const MemoryRegionOps next_timer_ops = {
> +    .read = next_timer_read,
> +    .write = next_timer_write,
> +    .valid.min_access_size = 1,
> +    .valid.max_access_size = 4,
> +    .endianness = DEVICE_BIG_ENDIAN,

... this should be in little endianness?

Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +};