qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 34/34] next-cube: replace boiler-plate GPL 2.0 or later li


From: Mark Cave-Ayland
Subject: Re: [PATCH v2 34/34] next-cube: replace boiler-plate GPL 2.0 or later license text with SPDX identifier
Date: Sat, 14 Dec 2024 20:38:06 +0000
User-agent: Mozilla Thunderbird

On 12/12/2024 17:28, Daniel P. Berrangé wrote:

On Thu, Dec 12, 2024 at 11:46:20AM +0000, Mark Cave-Ayland wrote:
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
  hw/m68k/next-cube.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c
index 1e96bb02f8..3c2f3e295c 100644
--- a/hw/m68k/next-cube.c
+++ b/hw/m68k/next-cube.c
@@ -4,10 +4,7 @@
   * Copyright (c) 2011 Bryce Lanham
   * Copyright (c) 2024 Mark Cave-Ayland
   *
- * This code is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published
- * by the Free Software Foundation; either version 2 of the License,
- * or (at your option) any later version.
+ * SPDX-License-Identifier: GPL-2.0-or-later
   */

While adding a SPDX-License-Identifier alongside existing header text
is acceptable, my view is that we should stay away from removing existing
license headers. There are some difficult questions wrt interpretation
of the GPL in this area & avoiding opening that can of worms would be
nice.

I remember you mentioned this before, but I wasn't sure if this would be mitigated by the fact that the code originated from GSoC? I'm sure I've seen at least one recent patch that made a similar change, but if there really are legal reasons not to allow changes of this type then I shall drop it from the series.


ATB,

Mark.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]