Re: [PATCH 6/9] vfio/migration: Rename vfio_devices_all_dirty_tracking()

[Joao Martins]

On 16/12/2024 09:46, Avihai Horon wrote:
> vfio_devices_all_dirty_tracking() is used to check if dirty page log
> sync is needed. However, besides checking the dirty page tracking
> status, it also checks the pre_copy_dirty_page_tracking flag.
> 
> Rename it to vfio_devices_log_sync_needed() which reflects its purpose
> more accurately and makes the code clearer as there are already several
> helpers with similar names.
> 
Yes! :)

> Signed-off-by: Avihai Horon <avihaih@nvidia.com>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>

> ---
>  hw/vfio/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 6e4654218a..dd8c5c52b5 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -195,7 +195,7 @@ bool vfio_devices_all_dirty_tracking_started(
>             bcontainer->dirty_pages_started;
>  }
>  
> -static bool vfio_devices_all_dirty_tracking(VFIOContainerBase *bcontainer)
> +static bool vfio_log_sync_needed(const VFIOContainerBase *bcontainer)
>  {
>      VFIODevice *vbasedev;
>  
> @@ -1368,7 +1368,7 @@ static void vfio_listener_log_sync(MemoryListener 
> *listener,
>          return;
>      }
>  
> -    if (vfio_devices_all_dirty_tracking(bcontainer)) {
> +    if (vfio_log_sync_needed(bcontainer)) {
>          ret = vfio_sync_dirty_bitmap(bcontainer, section, &local_err);
>          if (ret) {
>              error_report_err(local_err);