Re: [PATCH v2] tests/qtest/sse-timer-test: Add watchdog reset to sse-timer test

[Peter Maydell]

On Fri, 13 Dec 2024 at 22:40, Nabih Estefan <nabihestefan@google.com> wrote:
>
> V2: Removed scripts/meson-buildoptions.sh.tmp Extra file that slipped
> through the cracks and shouldn't be in this patch
>
> Recent CDMSK Watchdog changes (eff9dc5660fad3a610171c56a5ec3fada245e519)
> updated the CDMSK APB Watchdog to not free run out of reset. That led to
> this test failing since it never triggers the watchdog to start running.
> No watchdog running means that the timer and counter in the test cannot
> start, leading to failures in the assert statements throughout the test.
> Adding a reset and enable of the watchdog to the reset function solves
> this problem by enabling the watchdog and thus letting the timer and
> counter run as expected

I don't understand this. The watchdog on this board is not
an input to the timer/counter, so whether the watchdog is
running or not should not affect whether the timer and
counter can run. Something else must be going wrong.

> Also renaming the reset_counter_and_timer function since it now also
> affects the watchdog.
>
> To reproduce the failure at HEAD:
> ./configure --target-list=arm-softmmu
> make -j check-report-qtest-arm.junit.xml

This does not fail for me, and nor does running just the
single test case in a loop. (Tested on ubuntu 22.04 with
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0.)

thanks
-- PMM