Re: [PATCH 0/9] migration: Drop/unexport migration_is_device() and migration_is_active()

[Avihai Horon]

On 16/12/2024 23:43, Cédric Le Goater wrote:
> External email: Use caution opening links or attachments
>
>
> On 12/16/24 10:46, Avihai Horon wrote:
> > Hello,
> >
> > This follows up on Peter's series [1] to simplify migration status API
> > to a single migration_is_running() function.
> >
> > Peter's series tried to drop migration_is_device() and
> > migration_is_active(), however VFIO used them to check if dirty page
> > tracking has been started in order to avoid errors in log sync, so they
> > couldn't simply be dropped without some preliminary cleanups.
> >
> > This series handles these preliminary cleanups and eventually drops
> > migration_is_device() and unexports migration_is_active().
> >
> > The series has been migration tested with the following:
> > - VFIO device dirty tracking.
> > - Legacy VFIO iommu dirty tracking.
> > - vIOMMU + Legacy VFIO iommu dirty tracking (migration with vIOMMU is
> >    currently blocked, so I used a patched QEMU to allow it).
> >
> > I didn't test it with iommu DPT as I don't have access to such HW.
> > Cedric, I remember you said that you have such HW, it would be very
> > helpful if you could test it.
>
> Yes. I can.

Thanks.

> I am bit busy now and I only looked quickly at the comments. I understand
> from Joao that it shouldn't be too complex to change the VFIO dirty
> tracking engines to use calc-dirty-rate, which I agree would useful.

Sure, will do.

> How far are we from that ? 

Not far, I hope I can send v2 later this week.

> We are early in the QEMU cycle and this series
> looks ok, may be needs one respin. Should we merge it first ? I feel this
> would be good to have before the migration cleanups and the next version
> of Maciej's multifd series.
Agreed.

Thanks.