Re: [PATCH v3 0/2] Convert the intel_iommu avocado test

[Michael S. Tsirkin]

On Tue, Dec 17, 2024 at 01:15:48PM +0100, Thomas Huth wrote:
> The first patch introduces a helper function for retrieving the
> hostfwd ports from QEMU.
> We then use this helper function to run a HTTP server in the guest
> in the second patch to exercise the network of the guest.

Good stuff

Acked-by: Michael S. Tsirkin <mst@redhat.com>


> v3:
> - Use the new hostfwd helper function instead of trying to probe
>   for an unused port on the host
> - Use a constant for the guest port 8080
> 
> Thomas Huth (2):
>   tests/functional: Add a helper function for retrieving the hostfwd
>     port
>   tests/functional: Convert the intel_iommu avocado test
> 
>  MAINTAINERS                                   |   1 +
>  tests/functional/meson.build                  |   2 +
>  tests/functional/qemu_test/utils.py           |   7 +
>  tests/functional/test_info_usernet.py         |   8 +-
>  .../test_intel_iommu.py}                      | 191 +++++++++++-------
>  5 files changed, 135 insertions(+), 74 deletions(-)
>  rename tests/{avocado/intel_iommu.py => functional/test_intel_iommu.py} (26%)
>  mode change 100644 => 100755
> 
> -- 
> 2.47.1