[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/6] qdev: Change qdev_prop_pci_devfn member @name from "int32" t
From: |
Markus Armbruster |
Subject: |
[PATCH 2/6] qdev: Change qdev_prop_pci_devfn member @name from "int32" to "str" |
Date: |
Tue, 17 Dec 2024 15:28:50 +0100 |
Properties using qdev_prop_pci_devfn initially accepted a string of
the form "DEV.FN" or "DEV" where DEV and FN are in hexadecimal.
Member @name was "pci-devfn" initially.
Commit b403298adb5 (qdev: make the non-legacy pci address property
accept an integer) changed them to additionally accept integers: bits
3..7 are DEV, and bits 0..2 are FN. This is inaccessible externally
in device_add so far.
The commit also changed @name to "int32", and set member @legacy-name
to "pci-devfn". Together, this kept QMP command
device-list-properties unaffected: it used @name only when
@legacy_name was null.
Commit 07d09c58dbb (qmp: Print descriptions of object properties)
quietly dumbed that down to use @name always, and the next commit
18b91a3e082q (qdev: Drop legacy_name from qdev properties) dropped
member @legacy_name. This changed the value of @type reported by QMP
command device-list-properties from "pci-devfn" to "int32".
But "int32" is misleading: device_add actually wants QAPI type "str".
So change @name to that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/core/qdev-properties-system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index 22ea1ed358..3177678861 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -882,7 +882,7 @@ static int print_pci_devfn(Object *obj, Property *prop,
char *dest,
}
const PropertyInfo qdev_prop_pci_devfn = {
- .name = "int32",
+ .name = "str",
.description = "Slot and optional function number, example: 06.0 or 06",
.print = print_pci_devfn,
.get = qdev_propinfo_get_int32,
--
2.47.0
- [PATCH 0/6] Property type reporting improvements, Markus Armbruster, 2024/12/17
- [PATCH 4/6] qdev: Change values of PropertyInfo member @type to be QAPI types, Markus Armbruster, 2024/12/17
- [PATCH 2/6] qdev: Change qdev_prop_pci_devfn member @name from "int32" to "str",
Markus Armbruster <=
- [PATCH 6/6] qdev: Improve a few more PropertyInfo @description members, Markus Armbruster, 2024/12/17
- [PATCH 3/6] qdev: Rename PropertyInfo member @name to @type, Markus Armbruster, 2024/12/17
- [PATCH 1/6] qdev: Delete unused qdev_prop_enum, Markus Armbruster, 2024/12/17
- [PATCH 5/6] qdev: Improve PropertyInfo member @description for enum properties, Markus Armbruster, 2024/12/17