[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 05/32] tests/functional: simplify 'which' implementation
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v3 05/32] tests/functional: simplify 'which' implementation |
Date: |
Tue, 17 Dec 2024 15:59:26 +0000 |
The 'access' check implies the file exists.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/functional/qemu_test/cmd.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/functional/qemu_test/cmd.py
b/tests/functional/qemu_test/cmd.py
index 4106f1ee7c..600e0509db 100644
--- a/tests/functional/qemu_test/cmd.py
+++ b/tests/functional/qemu_test/cmd.py
@@ -25,7 +25,7 @@ def which(tool):
paths=os.getenv('PATH')
for p in paths.split(os.path.pathsep):
p = os.path.join(p, tool)
- if os.path.exists(p) and os.access(p, os.X_OK):
+ if os.access(p, os.X_OK):
return p
return None
--
2.46.0
- [PATCH v3 00/32] tests/functional: various improvements wrt assets/scratch files, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 01/32] tests/functional: add execute permission to aspeed tests, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 02/32] tests/functional: remove many unused imports, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 04/32] tests/functional: remove duplicated 'which' function impl, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 05/32] tests/functional: simplify 'which' implementation,
Daniel P . Berrangé <=
- [PATCH v3 03/32] tests/functional: resolve str(Asset) to cache file path, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 06/32] tests/functional: drop 'tesseract_available' helper, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 07/32] tests/functional: introduce some helpful decorators, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 08/32] tests/functional: switch to new test skip decorators, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 10/32] tests/functional: add helpers for building file paths, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 09/32] tests/functional: drop 'has_cmd' and 'has_cmds' helpers, Daniel P . Berrangé, 2024/12/17
- [PATCH v3 11/32] tests/functional: switch over to using self.log_file(...), Daniel P . Berrangé, 2024/12/17
- [PATCH v3 12/32] tests/functional: switch over to using self.build_file(...), Daniel P . Berrangé, 2024/12/17