[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/17] migration/multifd: Remove sync processing on postcopy
From: |
Fabiano Rosas |
Subject: |
[PULL 06/17] migration/multifd: Remove sync processing on postcopy |
Date: |
Tue, 17 Dec 2024 14:48:44 -0300 |
From: Peter Xu <peterx@redhat.com>
Multifd never worked with postcopy, at least yet so far.
Remove the sync processing there, because it's confusing, and they should
never appear. Now if RAM_SAVE_FLAG_MULTIFD_FLUSH is observed, we fail hard
instead of trying to invoke multifd code.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20241206224755.1108686-6-peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
migration/ram.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 90811aabd4..154ff5abd4 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3772,15 +3772,7 @@ int ram_load_postcopy(QEMUFile *f, int channel)
TARGET_PAGE_SIZE);
}
break;
- case RAM_SAVE_FLAG_MULTIFD_FLUSH:
- multifd_recv_sync_main();
- break;
case RAM_SAVE_FLAG_EOS:
- /* normal exit */
- if (migrate_multifd() &&
- migrate_multifd_flush_after_each_section()) {
- multifd_recv_sync_main();
- }
break;
default:
error_report("Unknown combination of migration flags: 0x%x"
--
2.35.3
- [PULL 00/17] Migration patches for 2024-12-17, Fabiano Rosas, 2024/12/17
- [PULL 05/17] migration/multifd: Unify RAM_SAVE_FLAG_MULTIFD_FLUSH messages, Fabiano Rosas, 2024/12/17
- [PULL 04/17] migration/ram: Move RAM_SAVE_FLAG* into ram.h, Fabiano Rosas, 2024/12/17
- [PULL 07/17] migration/multifd: Cleanup src flushes on condition check, Fabiano Rosas, 2024/12/17
- [PULL 01/17] migration/multifd: Fix compile error caused by page_size usage, Fabiano Rosas, 2024/12/17
- [PULL 03/17] migration/multifd: Allow to sync with sender threads only, Fabiano Rosas, 2024/12/17
- [PULL 06/17] migration/multifd: Remove sync processing on postcopy,
Fabiano Rosas <=
- [PULL 09/17] migration/multifd: Fix compat with QEMU < 9.0, Fabiano Rosas, 2024/12/17
- [PULL 02/17] migration/multifd: Further remove the SYNC on complete, Fabiano Rosas, 2024/12/17
- [PULL 10/17] s390x: Fix CSS migration, Fabiano Rosas, 2024/12/17
- [PULL 08/17] migration/multifd: Document the reason to sync for save_setup(), Fabiano Rosas, 2024/12/17
- [PULL 11/17] migration: Add helper to get target runstate, Fabiano Rosas, 2024/12/17
- [PULL 12/17] qmp/cont: Only activate disks if migration completed, Fabiano Rosas, 2024/12/17
- [PULL 13/17] migration/block: Make late-block-active the default, Fabiano Rosas, 2024/12/17
- [PULL 15/17] migration/block: Fix possible race with block_inactive, Fabiano Rosas, 2024/12/17
- [PULL 17/17] tests/qtest/migration: Fix compile errors when CONFIG_UADK is set, Fabiano Rosas, 2024/12/17
- [PULL 14/17] migration/block: Apply late-block-active behavior to postcopy, Fabiano Rosas, 2024/12/17