Re: [PATCH 08/46] tcg/optimize: Use fold_masks_zs in fold_bswap

[Pierrick Bouvier]

On 12/10/24 07:23, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 285407ce05..3363ebd48c 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1082,7 +1082,6 @@ static bool fold_masks_zsa(OptContext *ctx, TCGOp *op, 
> uint64_t z_mask,
>       return true;
>   }
>   
> -__attribute__((unused))
>   static bool fold_masks_zs(OptContext *ctx, TCGOp *op,
>                             uint64_t z_mask, uint64_t s_mask)
>   {
> @@ -1528,10 +1527,8 @@ static bool fold_bswap(OptContext *ctx, TCGOp *op)
>           s_mask = 0;
>           break;
>       }
> -    ctx->z_mask = z_mask;
> -    ctx->s_mask = s_mask;
>   
> -    return fold_masks(ctx, op);
> +    return fold_masks_zs(ctx, op, z_mask, s_mask);
>   }
>   
>   static bool fold_call(OptContext *ctx, TCGOp *op)

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>