Re: [PATCH] tests/qtest/migration: Restore include for postcopy

[Peter Xu]

On Tue, Dec 17, 2024 at 06:22:01PM -0300, Fabiano Rosas wrote:
> Commit 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to
> utils") moved the ufd_version_check() function to another file but
> failed to bring along the <sys/syscall> include, which is necessary to
> pull in <asm/unistd.h> for __NR_userfaultd.
> 
> Restore the missing include.

Ohhhhhhh.. so postcopy tests will always be skipped as of now?  Maybe worth
explicit mention that in the commit message if so, only when you merge.

> 
> While here, remove the ifdef __linux__ that's redundant and fix a
> couple of typos.
> 
> Fixes: 124a3c58b8 ("tests/qtest/migration: Move ufd_version_check to utils")
> Signed-off-by: Fabiano Rosas <farosas@suse.de>

Reviewed-by: Peter Xu <peterx@redhat.com>

Maybe we don't need to be as careful on old kernels anymore especially in
tests, because userfaultfd syscall existed for ~10 years. So if we want we
can start requiring __NR_userfaultfd present for __linux__, then no way to
miss such spot next time.

-- 
Peter Xu