[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/38] tests/functional: move uncompress handling into new uncompr
From: |
Thomas Huth |
Subject: |
[PULL 17/38] tests/functional: move uncompress handling into new uncompress.py file |
Date: |
Wed, 18 Dec 2024 12:09:37 +0100 |
From: Daniel P. Berrangé <berrange@redhat.com>
More uncompress related code will be added shortly, so having a
separate file makes more sense.
The utils.py imports the functions from archive.py, so that
existing callers don't need to be modified. This avoids
redundant code churn until later in the series when all
calls will be adapted for other reasons.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20241217155953.3950506-18-berrange@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/qemu_test/uncompress.py | 36 ++++++++++++++++++++++++
tests/functional/qemu_test/utils.py | 27 ++----------------
2 files changed, 38 insertions(+), 25 deletions(-)
create mode 100644 tests/functional/qemu_test/uncompress.py
diff --git a/tests/functional/qemu_test/uncompress.py
b/tests/functional/qemu_test/uncompress.py
new file mode 100644
index 0000000000..955170df65
--- /dev/null
+++ b/tests/functional/qemu_test/uncompress.py
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Utilities for python-based QEMU tests
+#
+# Copyright 2024 Red Hat, Inc.
+#
+# Authors:
+# Thomas Huth <thuth@redhat.com>
+
+import gzip
+import lzma
+import os
+import shutil
+
+
+def gzip_uncompress(gz_path, output_path):
+ if os.path.exists(output_path):
+ return
+ with gzip.open(gz_path, 'rb') as gz_in:
+ try:
+ with open(output_path, 'wb') as raw_out:
+ shutil.copyfileobj(gz_in, raw_out)
+ except:
+ os.remove(output_path)
+ raise
+
+def lzma_uncompress(xz_path, output_path):
+ if os.path.exists(output_path):
+ return
+ with lzma.open(xz_path, 'rb') as lzma_in:
+ try:
+ with open(output_path, 'wb') as raw_out:
+ shutil.copyfileobj(lzma_in, raw_out)
+ except:
+ os.remove(output_path)
+ raise
diff --git a/tests/functional/qemu_test/utils.py
b/tests/functional/qemu_test/utils.py
index 5ce1c4388e..6b87af4414 100644
--- a/tests/functional/qemu_test/utils.py
+++ b/tests/functional/qemu_test/utils.py
@@ -8,13 +8,12 @@
# This work is licensed under the terms of the GNU GPL, version 2 or
# later. See the COPYING file in the top-level directory.
-import gzip
-import lzma
import os
-import shutil
from .archive import tar_extract as archive_extract
from .archive import cpio_extract
+from .uncompress import gzip_uncompress
+from .uncompress import lzma_uncompress
"""
Round up to next power of 2
@@ -36,25 +35,3 @@ def image_pow2ceil_expand(path):
if size != size_aligned:
with open(path, 'ab+') as fd:
fd.truncate(size_aligned)
-
-def gzip_uncompress(gz_path, output_path):
- if os.path.exists(output_path):
- return
- with gzip.open(gz_path, 'rb') as gz_in:
- try:
- with open(output_path, 'wb') as raw_out:
- shutil.copyfileobj(gz_in, raw_out)
- except:
- os.remove(output_path)
- raise
-
-def lzma_uncompress(xz_path, output_path):
- if os.path.exists(output_path):
- return
- with lzma.open(xz_path, 'rb') as lzma_in:
- try:
- with open(output_path, 'wb') as raw_out:
- shutil.copyfileobj(lzma_in, raw_out)
- except:
- os.remove(output_path)
- raise
--
2.47.1
- [PULL 06/38] tests/functional: drop 'tesseract_available' helper, (continued)
- [PULL 06/38] tests/functional: drop 'tesseract_available' helper, Thomas Huth, 2024/12/18
- [PULL 07/38] tests/functional: introduce some helpful decorators, Thomas Huth, 2024/12/18
- [PULL 08/38] tests/functional: switch to new test skip decorators, Thomas Huth, 2024/12/18
- [PULL 10/38] tests/functional: add helpers for building file paths, Thomas Huth, 2024/12/18
- [PULL 09/38] tests/functional: drop 'has_cmd' and 'has_cmds' helpers, Thomas Huth, 2024/12/18
- [PULL 11/38] tests/functional: switch over to using self.log_file(...), Thomas Huth, 2024/12/18
- [PULL 12/38] tests/functional: switch over to using self.build_file(...), Thomas Huth, 2024/12/18
- [PULL 13/38] tests/functional: switch over to using self.data_file(...), Thomas Huth, 2024/12/18
- [PULL 15/38] tests/functional: remove redundant 'rmtree' call, Thomas Huth, 2024/12/18
- [PULL 16/38] tests/functional: move archive handling into new archive.py file, Thomas Huth, 2024/12/18
- [PULL 17/38] tests/functional: move uncompress handling into new uncompress.py file,
Thomas Huth <=
- [PULL 14/38] tests/functional: switch over to using self.scratch_file(), Thomas Huth, 2024/12/18
- [PULL 18/38] tests/functional: add common zip_extract helper, Thomas Huth, 2024/12/18
- [PULL 20/38] tests/functional: let cpio_extract accept filenames, Thomas Huth, 2024/12/18
- [PULL 19/38] tests/functional: add common deb_extract helper, Thomas Huth, 2024/12/18
- [PULL 21/38] tests/functional: add a generalized archive_extract, Thomas Huth, 2024/12/18
- [PULL 22/38] tests/functional: add 'archive_extract' to QemuBaseTest, Thomas Huth, 2024/12/18
- [PULL 23/38] tests/functional: convert tests to new archive_extract helper, Thomas Huth, 2024/12/18
- [PULL 24/38] tests/functional: add a generalized uncompress helper, Thomas Huth, 2024/12/18
- [PULL 25/38] tests/functional: add 'uncompress' to QemuBaseTest, Thomas Huth, 2024/12/18
- [PULL 26/38] tests/functional: convert tests to new uncompress helper, Thomas Huth, 2024/12/18