qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/7] rust: pl011: match break logic of C version


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/7] rust: pl011: match break logic of C version
Date: Wed, 18 Dec 2024 14:18:30 +0100
User-agent: Mozilla Thunderbird

On 12/12/24 18:21, Paolo Bonzini wrote:
Check loopback_enabled(), not fifo_enabled(), like the C code.

Also, set_break_error() must not happen until the break is read from
the FIFO.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
  rust/hw/char/pl011/src/device.rs | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]