[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] multifd: bugfix for incorrect migration data with QPL co
From: |
Peter Xu |
Subject: |
Re: [PATCH 2/3] multifd: bugfix for incorrect migration data with QPL compression |
Date: |
Wed, 18 Dec 2024 12:08:46 -0500 |
On Wed, Dec 18, 2024 at 05:14:12PM +0800, Yuan Liu wrote:
> When QPL compression is enabled on the migration channel and the same
> dirty page changes from a normal page to a zero page in the iterative
> memory copy, the dirty page will not be updated to a zero page again
> on the target side, resulting in incorrect memory data on the source
> and target sides.
>
> The root cause is that the target side does not record the normal pages
> to the receivedmap.
>
> The solution is to add ramblock_recv_bitmap_set_offset in target side
> to record the normal pages.
>
> Signed-off-by: Yuan Liu <yuan1.liu@intel.com>
> Reviewed-by: Jason Zeng <jason.zeng@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu