Re: [PATCH v2] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

[Marc-André Lureau]

Hi

On Thu, Dec 19, 2024 at 2:03 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
> >>> +static const TypeInfo vmfwupdate_device_info = {
> >>> +    .name          = TYPE_VMFWUPDATE,
> >>> +    .parent        = TYPE_DEVICE,
> >>
> >> What is the qdev API used here? Why not use a plain object?
> >
> > I wrote this taking vmcoreinfo device as starting point. I will leave this 
> > as is for now unless anyone has strong opinions.
>
> We shouldn't blindly copy/paste & spread possible design mistakes.
>
> Marc-André, any particular reason to implement vmcoreinfo using qdev
> and not plain object?
>

I don't remember (damn 8y ago..). It seems the design changed over
time during review, qdev might have been necessary and stayed this
way.