[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 02/10] hw/misc/vmcoreinfo: Rename opaque pointer as 'opaq
From: |
Daniel P . Berrangé |
Subject: |
Re: [RFC PATCH 02/10] hw/misc/vmcoreinfo: Rename opaque pointer as 'opaque' |
Date: |
Thu, 19 Dec 2024 16:55:30 +0000 |
User-agent: |
Mutt/2.2.13 (2024-03-09) |
On Thu, Dec 19, 2024 at 04:38:49PM +0100, Philippe Mathieu-Daudé wrote:
> Both QEMUResetHandler and FWCfgWriteCallback take an opaque
> pointer argument, no need to cast.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/misc/vmcoreinfo.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [RFC PATCH 01/10] hw/misc/vmcoreinfo: Declare QOM type using DEFINE_TYPES macro, (continued)
- [RFC PATCH 01/10] hw/misc/vmcoreinfo: Declare QOM type using DEFINE_TYPES macro, Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 04/10] hw/misc/vmcoreinfo: Rename VMCOREINFO_DEVICE -> TYPE_VMCOREINFO_DEVICE, Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 09/10] hw/misc/vmcoreinfo: Deprecate '-device vmcoreinfo', Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 05/10] hw/misc/vmcoreinfo: Convert to three-phase reset interface, Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 07/10] hw/misc/vmcoreinfo: Factor vmcoreinfo_device_realize() out, Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 02/10] hw/misc/vmcoreinfo: Rename opaque pointer as 'opaque', Philippe Mathieu-Daudé, 2024/12/19
- Re: [RFC PATCH 02/10] hw/misc/vmcoreinfo: Rename opaque pointer as 'opaque',
Daniel P . Berrangé <=
- [RFC PATCH 08/10] hw/misc/vmcoreinfo: Implement 'vmcore-info' object, Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH-for-10.2 10/10] hw/misc/vmcoreinfo: Remove legacy '-device vmcoreinfo', Philippe Mathieu-Daudé, 2024/12/19
- [RFC PATCH 06/10] hw/misc/vmcoreinfo: Move vmstate_vmcoreinfo[] around, Philippe Mathieu-Daudé, 2024/12/19
- Re: [RFC PATCH 00/10] hw/misc/vmcoreinfo: Convert from QDev to plain Object, Daniel P . Berrangé, 2024/12/19