qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] target/arm: change default pauth algorithm to impdef


From: Richard Henderson
Subject: Re: [PATCH v2 2/3] target/arm: change default pauth algorithm to impdef
Date: Thu, 19 Dec 2024 15:10:48 -0800
User-agent: Mozilla Thunderbird

On 12/19/24 10:32, Pierrick Bouvier wrote:
Pointer authentication on aarch64 is pretty expensive (up to 50% of
execution time) when running a virtual machine with tcg and -cpu max
(which enables pauth=on).

The advice is always: use pauth-impdef=on.
Our documentation even mentions it "by default" in
docs/system/introduction.rst.

Thus, we change the default to use impdef by default. This does not
affect kvm or hvf acceleration, since pauth algorithm used is the one
from host cpu.

This change is retro compatible, in terms of cli, with previous
versions, as the semantic of using -cpu max,pauth-impdef=on, and -cpu
max,pauth-qarma3=on is preserved.
The new option introduced in previous patch and matching old default is
-cpu max,pauth-qarma5=on.
It is retro compatible with migration as well, by defining a backcompat
property, that will use qarma5 by default for virt machine <= 9.2.
Tested by saving and restoring a vm from qemu 9.2.0 into qemu-master
(10.0) for cpus neoverse-n2 and max.

Signed-off-by: Pierrick Bouvier<pierrick.bouvier@linaro.org>
---
  docs/system/arm/cpu-features.rst |  2 +-
  docs/system/introduction.rst     |  2 +-
  target/arm/cpu.h                 |  3 +++
  hw/core/machine.c                |  4 +++-
  target/arm/cpu.c                 |  2 ++
  target/arm/cpu64.c               | 22 ++++++++++++++++------
  6 files changed, 26 insertions(+), 9 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]