[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/51] tcg/optimize: Use fold_masks_zs in fold_count_zeros
From: |
Richard Henderson |
Subject: |
[PATCH v3 11/51] tcg/optimize: Use fold_masks_zs in fold_count_zeros |
Date: |
Sun, 22 Dec 2024 08:24:06 -0800 |
Avoid the use of the OptContext slots. Find TempOptInfo once.
Compute s_mask from the union of the maximum count and the
op2 fallback for op1 being zero.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index 27b8f90453..b98597f500 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1550,10 +1550,12 @@ static bool fold_call(OptContext *ctx, TCGOp *op)
static bool fold_count_zeros(OptContext *ctx, TCGOp *op)
{
- uint64_t z_mask;
+ uint64_t z_mask, s_mask;
+ TempOptInfo *t1 = arg_info(op->args[1]);
+ TempOptInfo *t2 = arg_info(op->args[2]);
- if (arg_is_const(op->args[1])) {
- uint64_t t = arg_info(op->args[1])->val;
+ if (t1->is_const) {
+ uint64_t t = t1->val;
if (t != 0) {
t = do_constant_folding(op->opc, ctx->type, t, 0);
@@ -1572,8 +1574,11 @@ static bool fold_count_zeros(OptContext *ctx, TCGOp *op)
default:
g_assert_not_reached();
}
- ctx->z_mask = arg_info(op->args[2])->z_mask | z_mask;
- return false;
+ s_mask = ~z_mask;
+ z_mask |= t2->z_mask;
+ s_mask &= t2->s_mask;
+
+ return fold_masks_zs(ctx, op, z_mask, s_mask);
}
static bool fold_ctpop(OptContext *ctx, TCGOp *op)
--
2.43.0
- Re: [PATCH v3 06/51] tcg/optimize: Change representation of s_mask, (continued)
- [PATCH v3 35/51] tcg/optimize: Use fold_masks_s in fold_negsetcond, Richard Henderson, 2024/12/22
- [PATCH v3 29/51] tcg/optimize: Use fold_masks_zs in fold_orc, Richard Henderson, 2024/12/22
- [PATCH v3 33/51] tcg/optimize: Distinguish simplification in fold_setcond_zmask, Richard Henderson, 2024/12/22
- [PATCH v3 09/51] tcg/optimize: Use fold_masks_zs in fold_andc, Richard Henderson, 2024/12/22
- [PATCH v3 04/51] tcg/optimize: Split out fold_masks_zs, Richard Henderson, 2024/12/22
- [PATCH v3 07/51] tcg/optimize: Use finish_folding in fold_add, fold_add_vec, fold_addsub2, Richard Henderson, 2024/12/22
- [PATCH v3 10/51] tcg/optimize: Use fold_masks_zs in fold_bswap, Richard Henderson, 2024/12/22
- [PATCH v3 16/51] tcg/optimize: Use finish_folding in fold_dup, fold_dup2, Richard Henderson, 2024/12/22
- [PATCH v3 12/51] tcg/optimize: Use fold_masks_z in fold_ctpop, Richard Henderson, 2024/12/22
- [PATCH v3 11/51] tcg/optimize: Use fold_masks_zs in fold_count_zeros,
Richard Henderson <=
- [PATCH v3 15/51] tcg/optimize: Use finish_folding in fold_divide, Richard Henderson, 2024/12/22
- [PATCH v3 17/51] tcg/optimize: Use fold_masks_s in fold_eqv, Richard Henderson, 2024/12/22
- [PATCH v3 22/51] tcg/optimize: Use fold_masks_zs in fold_movcond, Richard Henderson, 2024/12/22
- [PATCH v3 25/51] tcg/optimize: Use fold_masks_z in fold_neg_no_const, Richard Henderson, 2024/12/22
- [PATCH v3 39/51] tcg/optimize: Use fold_masks_zs in fold_sextract, Richard Henderson, 2024/12/22
- [PATCH v3 27/51] tcg/optimize: Use fold_masks_s in fold_not, Richard Henderson, 2024/12/22
- [PATCH v3 38/51] tcg/optimize: Use finish_folding in fold_cmpsel_vec, Richard Henderson, 2024/12/22
- [PATCH v3 31/51] tcg/optimize: Return true from fold_qemu_st, fold_tcg_st, Richard Henderson, 2024/12/22
- [PATCH v3 36/51] tcg/optimize: Use fold_masks_z in fold_setcond2, Richard Henderson, 2024/12/22
- [PATCH v3 28/51] tcg/optimize: Use fold_masks_zs in fold_or, Richard Henderson, 2024/12/22