Re: [PATCH v3 49/51] tcg/optimize: Re-enable sign-mask optimizations

[Pierrick Bouvier]

On 12/22/24 08:24, Richard Henderson wrote:
> All instances of s_mask have been converted to the new
> representation.  We can now re-enable usage.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/optimize.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index 902c219032..607697e19c 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1780,7 +1780,7 @@ static bool fold_exts(OptContext *ctx, TCGOp *op)
>           g_assert_not_reached();
>       }
>   
> -    if (0 && !type_change && fold_affected_mask(ctx, op, s_mask & ~s_mask_old)) {
> +    if (!type_change && fold_affected_mask(ctx, op, s_mask & ~s_mask_old)) {
>           return true;
>       }
>   
> @@ -2489,7 +2489,7 @@ static bool fold_sextract(OptContext *ctx, TCGOp *op)
>       s_mask = s_mask_old >> pos;
>       s_mask |= -1ull << (len - 1);
>   
> -    if (0 && pos == 0 && fold_affected_mask(ctx, op, s_mask & ~s_mask_old)) {
> +    if (pos == 0 && fold_affected_mask(ctx, op, s_mask & ~s_mask_old)) {
>           return true;
>       }
>   

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>