Re: [PATCH v3 01/14] s390x/s390-virtio-ccw: don't crash on weird RAM sizes

[David Hildenbrand]

On 24.12.24 13:32, Michael Tokarev wrote:
> 19.12.2024 17:41, David Hildenbrand wrote:
> > KVM is not happy when starting a VM with weird RAM sizes:
> >
> >     # qemu-system-s390x --enable-kvm --nographic -m 1234K
> >     qemu-system-s390x: kvm_set_user_memory_region: KVM_SET_USER_MEMORY_REGION
> >       failed, slot=0, start=0x0, size=0x244000: Invalid argument
> >     kvm_set_phys_mem: error registering slot: Invalid argument
> >     Aborted (core dumped)
> >
> > Let's handle that in a better way by rejecting such weird RAM sizes
> > right from the start:
> >
> >     # qemu-system-s390x --enable-kvm --nographic -m 1234K
> >     qemu-system-s390x: ram size must be multiples of 1 MiB
>
> Shouldn't this one be picked for qemu-stable?  Seems like a good
> bugfix to me.  Picked up for current stable releases for now, please
> let me know if I shouldn't.

Yes, better to have it in qemu-stable, so it would be greta if you could 
pick that as well (already upstream).

Thanks!

--
Cheers,

David / dhildenb