[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] hw/loongarch/boot: Refactor EFI booting protocol gene
From: |
Jiaxun Yang |
Subject: |
Re: [PATCH v3 1/3] hw/loongarch/boot: Refactor EFI booting protocol generation |
Date: |
Tue, 24 Dec 2024 18:35:37 +0000 |
在2024年12月24日十二月 下午4:00,Philippe Mathieu-Daudé写道:
[...]
> I'd prefer we avoid macros and use the ld/stN API, passing the
> size as argument:
>
> stn_le_p(&boot_memmap->desc_size, size,
> sizeof(efi_memory_desc_t));
>
> Ideally splitting the patch in 3, first convert to use the API
> as stn_le_p(ptr, 8, value), then second patch propagate the size,
> and the third add the size=4 case.
>
Hmm, the data structure of 32 bit variant is not exactly same as the 64bit
variant.
That’s why those macros are required to select the proper struct.
Anyway, merry Christmas!
Thanks
--
- Jiaxun