[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 36/72] tcg/optimize: Distinguish simplification in fold_setcond_zm
From: |
Richard Henderson |
Subject: |
[PULL 36/72] tcg/optimize: Distinguish simplification in fold_setcond_zmask |
Date: |
Tue, 24 Dec 2024 12:04:45 -0800 |
Change return from bool to int; distinguish between
complete folding, simplification, and no change.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index e78f5a79a3..678015a94a 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -2155,7 +2155,8 @@ static bool fold_remainder(OptContext *ctx, TCGOp *op)
return finish_folding(ctx, op);
}
-static bool fold_setcond_zmask(OptContext *ctx, TCGOp *op, bool neg)
+/* Return 1 if finished, -1 if simplified, 0 if unchanged. */
+static int fold_setcond_zmask(OptContext *ctx, TCGOp *op, bool neg)
{
uint64_t a_zmask, b_val;
TCGCond cond;
@@ -2250,11 +2251,10 @@ static bool fold_setcond_zmask(OptContext *ctx, TCGOp
*op, bool neg)
op->opc = xor_opc;
op->args[2] = arg_new_constant(ctx, 1);
}
- return false;
+ return -1;
}
}
-
- return false;
+ return 0;
}
static void fold_setcond_tst_pow2(OptContext *ctx, TCGOp *op, bool neg)
@@ -2359,10 +2359,13 @@ static bool fold_setcond(OptContext *ctx, TCGOp *op)
return tcg_opt_gen_movi(ctx, op, op->args[0], i);
}
- if (fold_setcond_zmask(ctx, op, false)) {
+ i = fold_setcond_zmask(ctx, op, false);
+ if (i > 0) {
return true;
}
- fold_setcond_tst_pow2(ctx, op, false);
+ if (i == 0) {
+ fold_setcond_tst_pow2(ctx, op, false);
+ }
ctx->z_mask = 1;
return false;
@@ -2376,10 +2379,13 @@ static bool fold_negsetcond(OptContext *ctx, TCGOp *op)
return tcg_opt_gen_movi(ctx, op, op->args[0], -i);
}
- if (fold_setcond_zmask(ctx, op, true)) {
+ i = fold_setcond_zmask(ctx, op, true);
+ if (i > 0) {
return true;
}
- fold_setcond_tst_pow2(ctx, op, true);
+ if (i == 0) {
+ fold_setcond_tst_pow2(ctx, op, true);
+ }
/* Value is {0,-1} so all bits are repetitions of the sign. */
ctx->s_mask = -1;
--
2.43.0
- [PULL 02/72] plugins: optimize cpu_index code generation, (continued)
- [PULL 02/72] plugins: optimize cpu_index code generation, Richard Henderson, 2024/12/24
- [PULL 23/72] tcg/optimize: Use fold_masks_zs in fold_exts, Richard Henderson, 2024/12/24
- [PULL 38/72] tcg/optimize: Use fold_masks_s in fold_negsetcond, Richard Henderson, 2024/12/24
- [PULL 39/72] tcg/optimize: Use fold_masks_z in fold_setcond2, Richard Henderson, 2024/12/24
- [PULL 11/72] tcg/optimize: Use fold_masks_zs in fold_and, Richard Henderson, 2024/12/24
- [PULL 33/72] tcg/optimize: Use fold_masks_zs in fold_qemu_ld, Richard Henderson, 2024/12/24
- [PULL 20/72] tcg/optimize: Use fold_masks_s in fold_eqv, Richard Henderson, 2024/12/24
- [PULL 22/72] tcg/optimize: Use finish_folding in fold_extract2, Richard Henderson, 2024/12/24
- [PULL 28/72] tcg/optimize: Use fold_masks_z in fold_neg_no_const, Richard Henderson, 2024/12/24
- [PULL 27/72] tcg/optimize: Use fold_masks_s in fold_nand, Richard Henderson, 2024/12/24
- [PULL 36/72] tcg/optimize: Distinguish simplification in fold_setcond_zmask,
Richard Henderson <=
- [PULL 37/72] tcg/optimize: Use fold_masks_z in fold_setcond, Richard Henderson, 2024/12/24
- [PULL 40/72] tcg/optimize: Use finish_folding in fold_cmp_vec, Richard Henderson, 2024/12/24
- [PULL 41/72] tcg/optimize: Use finish_folding in fold_cmpsel_vec, Richard Henderson, 2024/12/24
- [PULL 45/72] tcg/optimize: Use finish_folding in fold_sub, fold_sub_vec, Richard Henderson, 2024/12/24
- [PULL 43/72] tcg/optimize: Use fold_masks_zs, fold_masks_s in fold_shift, Richard Henderson, 2024/12/24
- [PULL 54/72] tcg/optimize: Move fold_cmp_vec, fold_cmpsel_vec into alphabetic sort, Richard Henderson, 2024/12/24
- [PULL 55/72] softfloat: Add float{16,32,64}_muladd_scalbn, Richard Henderson, 2024/12/24
- [PULL 57/72] target/sparc: Use float*_muladd_scalbn, Richard Henderson, 2024/12/24
- [PULL 59/72] softfloat: Add float_round_nearest_even_max, Richard Henderson, 2024/12/24
- [PULL 48/72] tcg/optimize: Use fold_masks_zs in fold_xor, Richard Henderson, 2024/12/24