Re: [PATCH 4/5] aspeed: Introduce ast2700-fc machine

[Philippe Mathieu-Daudé]

Hi Steven,

On 25/12/24 03:03, Steven Lee via wrote:
> This patch introduces a new machine, ast2700-fc, which supports all cores
> available in the AST27x0 SoC. In this machine
> - The first 4 cores are Cortex-A35 cores.
> - CPU 4 is designated as the SSP core.
> - CPU 5 is designated as the TSP core.
>
> Test Step:
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/ast2700-ssp.elf
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/ast2700-tsp.elf
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/bl31.bin
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/tee-raw.bin
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/u-boot-nodtb.bin
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/u-boot.dtb
>      wget 
> https://github.com/stevenlee7189/zephyr/releases/download/1.0.0/image-bmc.tar.zst
>      tar --zstd -xvf image-bmc.tar.zst
>
>      qemu-system-aarch64 -machine ast2700fc \
>        -device loader,force-raw=on,addr=0x400000000,file=u-boot-nodtb.bin \
>        -device loader,force-raw=on,addr=$((0x400000000 + 
> 748896)),file=u-boot.dtb\
>        -device loader,force-raw=on,addr=0x430000000,file=bl31.bin\
>        -device loader,force-raw=on,addr=0x430080000,file=tee-raw.bin\
>        -device loader,file=ast2700-ssp.elf,cpu-num=4 \
>        -device loader,file=ast2700-tsp.elf,cpu-num=5 \
>        -device loader,cpu-num=0,addr=0x430000000 \
>        -device loader,cpu-num=1,addr=0x430000000 \
>        -device loader,cpu-num=2,addr=0x430000000 \
>        -device loader,cpu-num=3,addr=0x430000000 \
>        -m 1G \
>        -drive file=image-bmc,if=mtd,format=raw \
>        -serial pty -serial pty -serial pty \
>        -S -nographic
>      char device redirected to /dev/pts/51 (label serial0)
>      char device redirected to /dev/pts/52 (label serial1)
>      char device redirected to /dev/pts/53 (label serial2)
>
>      tio /dev/pts/51
>      tio /dev/pts/52
>      tio /dev/pts/53
>      (qemu) c

Could we have a functional test included in this series please?

> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
> ---
>   hw/arm/aspeed_ast27x0-fc.c  | 211 ++++++++++++++++++++++++++++++++++++
>   hw/arm/meson.build          |   4 +-
>   include/hw/arm/aspeed_soc.h |  12 ++
>   3 files changed, 226 insertions(+), 1 deletion(-)
>   create mode 100644 hw/arm/aspeed_ast27x0-fc.c