[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/23] target/loongarch: Store some uint64_t values as tar
From: |
Jiaxun Yang |
Subject: |
Re: [PATCH v2 06/23] target/loongarch: Store some uint64_t values as target_ulong |
Date: |
Thu, 26 Dec 2024 22:58:25 +0000 |
在2024年12月26日十二月 下午10:48,Philippe Mathieu-Daudé写道:
> On 26/12/24 22:19, Jiaxun Yang wrote:
>> Store internal registers including GPRs, CSRs, and LBT scratchs
>> as target_ulong, as per architecture specification.
>>
>> The only exception here is tlb_misc, as it's only used by QEMU
>> internally and need keep to be 64bit to store all required fields.
>>
>> There is no migration ABI change, as target_ulong is uint64_t on
>> existing loongarch64 builds anyway.
>
> I'm working on a prototype series where target_ulong becomes uint64_t
> under TCG. This patch is going the opposite direction. Not sure what
> to say at this point (I'm not rejecting it, just wondering).
Does this mean TCGv will always be 64bit?
I'm doing this just to keep all TCG _tl load/store sane. If that's the
way to go, I'm happy to adopt full uint64_t approach.
Thanks
>
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> target/loongarch/cpu.c | 34 ++++++------
>> target/loongarch/cpu.h | 132
>> ++++++++++++++++++++++-----------------------
>> target/loongarch/machine.c | 120 ++++++++++++++++++++---------------------
>> 3 files changed, 143 insertions(+), 143 deletions(-)
--
- Jiaxun
- Re: [PATCH v2 01/23] target/loongarch: Enable rotr.w/rotri.w for LoongArch32, (continued)
- [PATCH v2 02/23] target/loongarch: Fix address generation for gen_sc, Jiaxun Yang, 2024/12/26
- [PATCH v2 03/23] target/loongarch: Fix PGD CSR for LoongArch32, Jiaxun Yang, 2024/12/26
- [PATCH v2 04/23] target/loongarch: Perform sign extension for IOCSR reads, Jiaxun Yang, 2024/12/26
- [PATCH v2 05/23] target/loongarch: Use target_ulong for iocsrrd helper results, Jiaxun Yang, 2024/12/26
- [PATCH v2 06/23] target/loongarch: Store some uint64_t values as target_ulong, Jiaxun Yang, 2024/12/26
- [PATCH v2 07/23] target/loongarch: Cast address to 64bit before DMW_64_VSEG shift, Jiaxun Yang, 2024/12/26
- [PATCH v2 08/23] target/loongarch: Fix some modifiers for log formatting, Jiaxun Yang, 2024/12/26
- [PATCH v2 09/23] target/loongarch: Use target_ulong for CSR helpers, Jiaxun Yang, 2024/12/26
- [PATCH v2 10/23] target/loongarch: Scrutinise TCG float translation for 32 bit build, Jiaxun Yang, 2024/12/26