[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 20/23] hw/loongarch/virt: Default to max32 CPU for LoongAr
From: |
Jiaxun Yang |
Subject: |
Re: [PATCH v2 20/23] hw/loongarch/virt: Default to max32 CPU for LoongArch 32 build |
Date: |
Thu, 26 Dec 2024 23:03:48 +0000 |
在2024年12月26日十二月 下午10:56,Philippe Mathieu-Daudé写道:
> On 26/12/24 22:19, Jiaxun Yang wrote:
>> la464 CPU is not available on LoongArch32. Use max32 which makes
>> more sense here.
>>
>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>> ---
>> hw/loongarch/virt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
>> index
>> 3a905cf71d46e3c5a29672f7bb73faedf1d29444..343d2e745e155d59f0ff17124b3c77ec9b3c111e
>> 100644
>> --- a/hw/loongarch/virt.c
>> +++ b/hw/loongarch/virt.c
>> @@ -1440,7 +1440,11 @@ static void virt_class_init(ObjectClass *oc, void
>> *data)
>> HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc);
>>
>> mc->init = virt_init;
>> +#if defined(TARGET_LOONGARCH64)
>> mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("la464");
>> +#elif defined(TARGET_LOONGARCH32)
>> + mc->default_cpu_type = LOONGARCH_CPU_TYPE_NAME("max32");
>
> Why can't we use it on LOONGARCH64?
I think many users are launching qemu-system-loongarch64 with default CPU,
better not to break them, so we only do max32 as default for
qemu-system-loongarch32.
Thanks
>
>> +#endif
>> mc->default_ram_id = "loongarch.ram";
>> mc->desc = "QEMU LoongArch Virtual Machine";
>> mc->max_cpus = LOONGARCH_MAX_CPUS;
>>
--
- Jiaxun
- Re: [PATCH v2 15/23] target/loongarch: Fix load type for gen_ll, (continued)
- [PATCH v2 16/23] target/loongarch: Define address space information for LoongArch32, Jiaxun Yang, 2024/12/26
- [PATCH v2 17/23] target/loongarch: Refactoring is_la64/is_va32 for LoongArch32, Jiaxun Yang, 2024/12/26
- [PATCH v2 18/23] target/loongarch: ifdef out 64 bit CPUs on 32 bit builds, Jiaxun Yang, 2024/12/26
- [PATCH v2 19/23] target/loongarch: Introduce max32 CPU type, Jiaxun Yang, 2024/12/26
- [PATCH v2 22/23] target/loongarch: Wire up LoongArch32 Kconfigs, Jiaxun Yang, 2024/12/26
- [PATCH v2 20/23] hw/loongarch/virt: Default to max32 CPU for LoongArch 32 build, Jiaxun Yang, 2024/12/26
- [PATCH v2 21/23] qapi/machine: Replace TARGET_LOONGARCH64 with TARGET_LOONGARCH, Jiaxun Yang, 2024/12/26
- [PATCH v2 23/23] config: Add loongarch32-softmmu target, Jiaxun Yang, 2024/12/26