qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks


From: Gabriel Barrantes
Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks
Date: Sat, 28 Dec 2024 01:16:57 +0000

>From 532af9eecee4695abb02b40f2c18b711370aa7d2 Mon Sep 17 00:00:00 2001
From: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
Date: Fri, 27 Dec 2024 18:02:32 -0600
Subject: [PATCH v2] backends/cryptodev-vhost-user: Fix local_error leaks

Do not propagate error to the upper, directly output the error to
avoid leaks.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2714
Fixes: 2fda101de07 ("virtio-crypto: Support asynchronous mode")

Signed-off-by: Gabriel Barrantes <gabriel.barrantes.dev@outlook.com>
---
Changes in v2:
  • Add full link to issue.
  • Add reference to first bad commit.
---  
backends/cryptodev-vhost-user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.
c
index 43efdf9747..f87172b330 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -281,8 +281,8 @@ static int cryptodev_vhost_user_create_session(
        break;
 
    default:
-        error_setg(&local_error, "Unsupported opcode :%" PRIu32 "",
-                   sess_info->op_code);
+        error_report("Unsupported opcode :%" PRIu32 "",
+                     sess_info->op_code);
        return -VIRTIO_CRYPTO_NOTSUPP;
    }
 
--  
2.34.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]