Re: [PATCH-for-9.2] hw/avr/arduino: Check for CPU types in machine_run_board_init()

[Philippe Mathieu-Daudé]

Hi Peter,

On 18/11/24 14:07, Peter Maydell wrote:
> On Mon, 18 Nov 2024 at 13:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > Leverage the common code introduced in commit c9cf636d48 ("machine:
> > Add a valid_cpu_types property") to check for the single valid CPU
> > type. This allows reporting an error for invalid CPUs:
> >
> >    $ qemu-system-avr -M 2009 -cpu avr51-avr-cpu
> >    qemu-system-avr: Invalid CPU model: avr51
> >    The only valid type is: avr5
>
> This is a nice user-convenience feature, but why for 9.2?
> We haven't bothered to error-check the user specified CPU
> before, and we still don't on many (non-avr) board types.

This patch was motivated by a confused user:
https://lore.kernel.org/qemu-devel/84975169-3c87-42c8-96e3-7ae724cc4692@linaro.org/

Not checking valid CPUs on boards which only support a limited
set looks like an open gate for more user complains.
IMHO checking them should be the rule, not the exceptions.

Back to this patch, do you object to it?

Regards,

Phil.