qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-10.0 v2] hw/i386/amd_iommu: Simplify non-KVM checks on XT


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-10.0 v2] hw/i386/amd_iommu: Simplify non-KVM checks on XTSup feature
Date: Tue, 31 Dec 2024 18:36:39 +0100
User-agent: Mozilla Thunderbird

On 29/11/24 16:58, Philippe Mathieu-Daudé wrote:
Generic code wanting to access KVM specific methods should
do so being protected by the 'kvm_enabled()' helper.

Doing so avoid link failures when optimization is disabled
(using --enable-debug), see for example commits c04cfb4596a
("hw/i386: fix short-circuit logic with non-optimizing builds")
and 0266aef8cd6 ("amd_iommu: Fix kvm_enable_x2apic link error
with clang in non-KVM builds").

XTSup feature depends on KVM, so protect the whole block
checking the XTSup feature with a check on whether KVM is
enabled.

Since x86_cpus_init() already checks APIC ID > 255 imply
kernel support for irqchip and X2APIC, remove the confuse
and unlikely reachable "AMD IOMMU xtsup=on requires support
on the KVM side" message.

Fix a type in "configuration" in error message.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
v2:
Rebased on merged 0266aef8cd6 ("amd_iommu: Fix kvm_enable_x2apic
link error with clang in non-KVM builds").
Supersedes: <20241129114113.33215-1-philmd@linaro.org>
---
  hw/i386/amd_iommu.c | 11 ++---------
  1 file changed, 2 insertions(+), 9 deletions(-)

Patch queued, thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]