|
From: | Philippe Mathieu-Daudé |
Subject: | Re: Ping (2): [PATCH v3] net/vmnet: Pad short Ethernet frames |
Date: | Tue, 31 Dec 2024 18:42:09 +0100 |
User-agent: | Mozilla Thunderbird |
Hi William, On 30/12/24 22:05, William Hooper wrote:
On Sat, Nov 2, 2024 at 1:56 PM William Hooper <wsh@wshooper.org> wrote:At least on macOS 12.7.2, vmnet doesn't pad Ethernet frames, such as the host's ARP replies, to the minimum size (60 bytes before the frame check sequence) defined in IEEE Std 802.3-2022, so guests' Ethernet device drivers may drop them with "frame too short" errors. This patch calls eth_pad_short_frame() to add padding, as in net/tap.c and net/slirp.c. Thanks to Bin Meng, Philippe Mathieu-Daudé, and Phil Dennis-Jordan for reviewing earlier versions. Signed-off-by: William Hooper <wsh@wshooper.org> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2058 Reviewed-by: Phil Dennis-Jordan <phil@philjordan.eu> --- net/vmnet-common.m | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)
Ping?
We missed this patch because: 1/ maintainers were not Cc'ed (Jason now added) $ ./scripts/get_maintainer.pl -f net/vmnet-common.m Jason Wang <jasowang@redhat.com> (maintainer:Network device ba...) "Philippe Mathieu-Daudé" <philmd@linaro.org> (odd fixer:Darwin (macOS, iOS)) 2/ it is buried as a reply on a previous patch, see [*]: "Send each new revision as a new top-level thread, rather than burying it in-reply-to an earlier revision, as many reviewers are not looking inside deep threads for new patches." Anyway, now queued! Regards, Phil.[*] https://www.qemu.org/docs/master/devel/submitting-a-patch.html#when-resending-patches-add-a-version-tag
[Prev in Thread] | Current Thread | [Next in Thread] |