Re: [PATCH v2 3/5] hw/gpio/aspeed: Fix definition of AspeedGPIOClass

[Cédric Le Goater]

On 6/4/25 13:53, Zhenzhong Duan wrote:
> AspeedGPIOClass's parent is SysBusDeviceClass rather than SysBusDevice.
>
> Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and 
> AST2500")
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>

omg. This is super old ... version 4.2.

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.



> ---
>   include/hw/gpio/aspeed_gpio.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/gpio/aspeed_gpio.h b/include/hw/gpio/aspeed_gpio.h
> index e1e6c54333..e6b2fe71b5 100644
> --- a/include/hw/gpio/aspeed_gpio.h
> +++ b/include/hw/gpio/aspeed_gpio.h
> @@ -70,7 +70,7 @@ typedef struct AspeedGPIOReg {
>   } AspeedGPIOReg;
>   
>   struct AspeedGPIOClass {
> -    SysBusDevice parent_obj;
> +    SysBusDeviceClass parent_class;
>       const GPIOSetProperties *props;
>       uint32_t nr_gpio_pins;
>       uint32_t nr_gpio_sets;