qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 01/19] hw/arm/virt: Only require TCG || QTest to use virt


From: Miguel Luis
Subject: Re: [RFC PATCH 01/19] hw/arm/virt: Only require TCG || QTest to use virtualization extension
Date: Wed, 11 Jun 2025 14:38:31 +0000

Hi Alex,

> On 11 Jun 2025, at 14:31, Alex Bennée <alex.bennee@linaro.org> wrote:
> 
> Miguel Luis <miguel.luis@oracle.com> writes:
> 
>> Hi Philippe,
>> 
>>> On 6 Jun 2025, at 16:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>> 
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>> hw/arm/virt.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
>>> index 9a6cd085a37..d55ce2c0f4e 100644
>>> --- a/hw/arm/virt.c
>>> +++ b/hw/arm/virt.c
>>> @@ -2205,7 +2205,7 @@ static void machvirt_init(MachineState *machine)
>>>        exit(1);
>>>    }
>>> 
>>> -    if (vms->virt && (kvm_enabled() || hvf_enabled())) {
>>> +    if (vms->virt && !tcg_enabled() && !qtest_enabled()) {
>> 
>> Does this means TCG won’t run aarch64 NV?
> 
> No - it just means we can't start in EL2 with anything but TCG (or
> qtest).

Oh, of course.. now that I read it again.

Apologies for the noise and thanks for clarifying.

Regards,
Miguel

> Currently we don't have NV support for KVM in QEMU.
> 
> 
> BTW Philippe isn't the same test needed above for secure (which can't be
> supported even with KVM NV support).
> 
>> 
>> Miguel
>> 
>>>        error_report("mach-virt: %s does not support providing "
>>>                     "Virtualization extensions to the guest CPU",
>>>                     current_accel_name());
>>> -- 
>>> 2.49.0
>>> 
>>> 
> 
> -- 
> Alex Bennée
> Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]