Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific

[Peter Maydell]

On 25 October 2012 15:38, Avik Sil <address@hidden> wrote:
> @@ -171,6 +171,7 @@ static QEMUMachine clipper_machine = {
>      .init = clipper_init,
>      .max_cpus = 4,
>      .is_default = 1,
> +    .default_machine_opts = DEFAULT_BOOT_ORDER,
>  };

> @@ -86,6 +86,7 @@ static QEMUMachine an5206_machine = {
>      .name = "an5206",
>      .desc = "Arnewsh 5206",
>      .init = an5206_init,
> +    .default_machine_opts = DEFAULT_BOOT_ORDER,
>  };

> +++ b/hw/axis_dev88.c
> @@ -355,6 +355,7 @@ static QEMUMachine axisdev88_machine = {
>      .desc = "AXIS devboard 88",
>      .init = axisdev88_init,
>      .is_default = 1,
> +    .default_machine_opts = DEFAULT_BOOT_ORDER,
>  };

The thing about a default is that you shouldn't have to
explicitly say it in every QEMUMachine struct... Please
make the code handle a NULL in the struct in a way
that means you don't need to touch every board.

-- PMM