Re: [Qemu-ppc] [PATCH 18/21] openpic: add basic support for MPIC v4.2

[Alexander Graf]

On 25.01.2013, at 20:28, Scott Wood wrote:

> On 01/25/2013 01:23:52 PM, Blue Swirl wrote:
>> On Fri, Jan 25, 2013 at 12:53 PM, Alexander Graf <address@hidden> wrote:
>> > +
>> > +static int inttgt_to_output(int inttgt)
>> > +{
>> > +    int i;
>> > +
>> > +    for (i = 0; i < ARRAY_SIZE(inttgt_output); i++) {
>> > +        if (inttgt_output[i][0] == inttgt) {
>> > +            return inttgt_output[i][1];
>> > +        }
>> > +    }
>> > +
>> > +    fprintf(stderr, "%s: unsupported inttgt %d\n", __func__, inttgt);
>> No objection, but how about converting this to qemu_log(LOG_UNIMP,...) later?
> 
> OK, didn't know that existed.

And there I thought qemu_log as only meant for -d (TCG - aka CPU emulation) :).


Alex