[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fp
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr |
|
Date: |
Tue, 19 Mar 2013 20:48:46 +0100 |
On 19.03.2013, at 19:32, Richard Henderson wrote:
> On 03/19/2013 10:20 AM, Fabien Chouteau wrote:
>> Cleaner solution indeed. I'll do the opposite, store_fpscr calls
>> helper_store_fpscr.
>
> The declarations won't be in the right places for that to work right.
>
> Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading
> "cpu_" prefix, and then helper_store_fpscr is declared (via macro) in helper.h
> and its definition should call the cpu.h function.
Heh :) Fabien did a clever workaround that one in his v2. Mind to check whether
it's ok for you?
Alex