[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling o
From: |
Tom Musta |
Subject: |
[Qemu-ppc] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling on PPC |
Date: |
Wed, 13 Aug 2014 14:04:46 -0500 |
The clock_nanosleep syscall is unusual in that it returns positive
numbers in error handling situations, versus returning -1 and setting
errno, or returning a negative errno value. On POWER, the kernel will
set the SO bit of CR0 to indicate failure in a syscall. QEMU has
generic handling to do this for syscalls with standard return values.
Add special case code for clock_nanosleep to handle CR0 properly.
Signed-off-by: Tom Musta <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
---
V2: Eliminated redundant "#if defined" condition per Peter Maydell's
review.
linux-user/syscall.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a20c2f7..fc828ae 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8999,6 +8999,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
ret = get_errno(clock_nanosleep(arg1, arg2, &ts, arg4 ? &ts : NULL));
if (arg4)
host_to_target_timespec(arg4, &ts);
+
+#if defined(TARGET_PPC)
+ /* clock_nanosleep is odd in that it returns positive errno values.
+ * On PPC, CR0 bit 3 should be set in such a situation. */
+ if (ret) {
+ ((CPUPPCState *)cpu_env)->crf[0] |= 1;
+ }
+#endif
break;
}
#endif
--
1.7.1
- [Qemu-ppc] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 01/13] linux-user: PPC64 semid_ds Doesnt Include _unused1 and _unused2, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 02/13] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 05/13] linux-user: Conditionally Pass Attribute Pointer to mq_open(), Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 03/13] linux-user: Properly Handle semun Structure In Cross-Endian Situations, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 06/13] linux-user: Detect Negative Message Sizes in msgsnd System Call, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 04/13] linux-user: Make ipc syscall's third argument an abi_long, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 08/13] linux-user: Detect fault in sched_rr_get_interval, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 07/13] linux-user: Handle NULL sched_param argument to sched_*, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 11/13] linux-user: clock_nanosleep errno Handling on PPC,
Tom Musta <=
- [Qemu-ppc] [V3 PATCH 09/13] linux-user: Move get_ppc64_abi, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 10/13] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 13/13] linux-user: writev Partial Writes, Tom Musta, 2014/08/13
- [Qemu-ppc] [V3 PATCH 12/13] linux-user: Support target-to-host translation of mlockall argument, Tom Musta, 2014/08/13
- Re: [Qemu-ppc] [Qemu-devel] [V3 PATCH 00/13] target-ppc: Linux-User Mode Bug Fixes for Power, Riku Voipio, 2014/08/14