Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] spapr: SPLPAR Characteristics

[Bharata B Rao]

On Fri, Jul 3, 2015 at 9:12 AM, Sam Bobroff <address@hidden> wrote:
> Improve the SPLPAR Characteristics information:
>
>     Add MaxPlatProcs: set to max_cpus, the maximum CPUs that could be
>     addded to the system.
>     Add DesMem: set to the initial memory of the system.
>     Add DesProcs: set to smp_cpus, the inital number of CPUs in the
>     system.
>
> These tokens and values are specified by PAPR.
>
> Signed-off-by: Sam Bobroff <address@hidden>
> ---
>  hw/ppc/spapr_rtas.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index 0f1ae55..a08254b 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -33,6 +33,7 @@
>  #include "hw/ppc/spapr.h"
>  #include "hw/ppc/spapr_vio.h"
>  #include "qapi-event.h"
> +#include "hw/boards.h"
>
>  #include <libfdt.h>
>
> @@ -190,8 +191,14 @@ static void rtas_ibm_get_system_parameter(PowerPCCPU 
> *cpu,
>
>      switch (parameter) {
>      case RTAS_SYSPARM_SPLPAR_CHARACTERISTICS: {
> -        char *param_val = g_strdup_printf("MaxEntCap=%d,MaxPlatProcs=%d",
> -                                          max_cpus, smp_cpus);
> +        char *param_val = g_strdup_printf("MaxEntCap=%d,"
> +                                          "DesMem=%lu,"
> +                                          "DesProcs=%d,"
> +                                          "MaxPlatProcs=%d",
> +                                          max_cpus,
> +                                          current_machine->ram_size / 1024 / 
> 1024,

May be you could use M_BYTE definition from qemu-common.h ?

Regards,
Bharata.