[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regio
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions |
Date: |
Thu, 23 Jul 2015 18:16:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 23/07/2015 17:09, Michael S. Tsirkin wrote:
> On Wed, Jul 22, 2015 at 01:54:59PM +0200, Laurent Vivier wrote:
>> From: Michael Roth <address@hidden>
>>
>> Some kernels program a 0 address for io regions. PCI 3.0 spec
>> section 6.2.5.1 doesn't seem to disallow this.
>>
>> Signed-off-by: Michael Roth <address@hidden>
>> [lvivier: add accept_addr_0 in PCIBus to conditionally allow addr 0,
>> as this can break other architectures]
>> Signed-off-by: Laurent Vivier <address@hidden>
>
> Should same thing apply to devices behind bridge too?
> Maybe the flag should be global, not per-bus.
yes, I agree, it could be good to store it in the machine class (thank
you David for the idea :) ).
Is it acceptable to add this in the function ?
sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(qdev_get_machine());
I'm going to modify my patch.
Laurent
- [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, (continued)
- [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Laurent Vivier, 2015/07/22
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Michael S. Tsirkin, 2015/07/22
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Alexander Graf, 2015/07/22
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Laurent Vivier, 2015/07/22
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Alexander Graf, 2015/07/22
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, David Gibson, 2015/07/23
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Alexander Graf, 2015/07/23
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Laurent Vivier, 2015/07/23
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Laurent Vivier, 2015/07/23
Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions, Michael S. Tsirkin, 2015/07/23
- Re: [Qemu-ppc] [PATCH|RFC 1/1] pci: allow 0 address for PCI IO/MEM regions,
Laurent Vivier <=
[Qemu-ppc] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Laurent Vivier, 2015/07/23
Re: [Qemu-ppc] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Benjamin Herrenschmidt, 2015/07/23
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Peter Maydell, 2015/07/23
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Michael S. Tsirkin, 2015/07/23
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Peter Maydell, 2015/07/23
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Peter Maydell, 2015/07/23
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] pci: allow 0 address for PCI IO/MEM regions, Michael Roth, 2015/07/23