Re: [Qemu-ppc] [RFC PATCH] spapr: Provide an error message when migration fails due to htab_shift mismatch

[David Gibson]

On Thu, Jul 30, 2015 at 08:25:15PM +0530, Bharata B Rao wrote:
> Include an error message when migration fails due to mismatch in
> htab_shift values at source and target. This should provide a bit more
> verbose message in addition to the current migration failure message
> that reads like:
> 
> qemu-system-ppc64: error while loading state for instance 0x0 of device 
> 'spapr/htab'
> 
> After this patch, the failure message will look like this:
> 
> qemu-system-ppc64: htab_shift mismatch: source 29 target 24
> qemu-system-ppc64: error while loading state for instance 0x0 of device 
> 'spapr/htab'
> 
> Signed-off-by: Bharata B Rao <address@hidden>

I've applied this to spapr-next and a new spapr-fix tree (intended for
fixes which should go to the current feature-frozen qemu, not just the
next one).  It's certainly better than the current cryptic failure.

Longer term I think we need to work harder to try to get the hash
table size the same at both ends though - we should rearrange things
so we get the size from the migration stream and then use that to feed
the hint to the kernel allocation.

Sorry I haven't looked properly yet at the patch you sent which works
towards that.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpov7meOteXO.pgp
Description: PGP signature